Skip to content

Commit df01645

Browse files
jacobqtargos
authored andcommitted
doc: correct entry for electron v4.0.4
`abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69. See: * electron/electron#16687 * https://github.com/electron/electron/releases/tag/v4.0.4 * electron/node-abi@9e4c1a6 PR-URL: #27394 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 6e2c8d0 commit df01645

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

doc/abi_version_registry.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
{ "modules": 72, "runtime": "node", "variant": "v8_7.4", "versions": "12.0.0-pre" },
55
{ "modules": 71, "runtime": "node", "variant": "v8_7.3", "versions": "12.0.0-pre" },
66
{ "modules": 70, "runtime": "electron", "variant": "electron", "versions": "5" },
7-
{ "modules": 69, "runtime": "electron", "variant": "electron", "versions": "^4.0.5" },
7+
{ "modules": 69, "runtime": "electron", "variant": "electron", "versions": "^4.0.4" },
88
{ "modules": 68, "runtime": "node", "variant": "v8_7.1", "versions": "12.0.0-pre" },
99
{ "modules": 67, "runtime": "node", "variant": "node", "versions": "11" },
1010
{ "modules": 66, "runtime": "node", "variant": "v8_6.9", "versions": "11.0.0-pre" },
1111
{ "modules": 65, "runtime": "node", "variant": "v8_6.8", "versions": "11.0.0-pre" },
1212
{ "modules": 65, "runtime": "node", "variant": "debian-openssl_1.1.1", "versions": "10" },
1313
{ "modules": 64, "runtime": "node", "variant": "node", "versions": "10" },
14-
{ "modules": 64, "runtime": "electron", "variant": "electron", "versions": ">=3 <4.0.5" },
14+
{ "modules": 64, "runtime": "electron", "variant": "electron", "versions": ">=3 <4.0.4" },
1515
{ "modules": 63, "runtime": "node", "variant": "v8_6.6", "versions": "10.0.0-pre" },
1616
{ "modules": 62, "runtime": "node", "variant": "v8_6.5", "versions": "10.0.0-pre" },
1717
{ "modules": 61, "runtime": "node", "variant": "v8_6.4", "versions": "10.0.0-pre" },

0 commit comments

Comments
 (0)