fixup! crypto: add optional callback to crypto.sign and crypto.verify

Author: panva

test/parallel/test-crypto-async-sign-verify.js

@@ -94,5 +94,17 @@ test('ec_secp256k1_public.pem', 'ec_secp256k1_private.pem', 'sha384',
      false, { dsaEncoding: 'der' });
 
 // ECDSA w/ ieee-p1363 signature encoding
+// TODO(@jasnell): this fails because the signature generated is actually a DER one
 test('ec_secp256k1_public.pem', 'ec_secp256k1_private.pem', 'sha384', false,
      { dsaEncoding: 'ieee-p1363' });
+
+// DSA w/ der signature encoding
+test('dsa_public_1025.pem', 'dsa_private_1025.pem', 'sha256',
+     false);
+test('dsa_public_1025.pem', 'dsa_private_1025.pem', 'sha256',
+     false, { dsaEncoding: 'der' });
+
+// DSA w/ ieee-p1363 signature encoding
+// TODO(@jasnell): this crashes
+test('dsa_public_1025.pem', 'dsa_private_1025.pem', 'sha256', false,
+     { dsaEncoding: 'ieee-p1363' });