Skip to content

Commit e021ca2

Browse files
committedJul 5, 2018
src: remove using directives from spawn_sync.h
I noticed that there were a few using declarations what were unused and instead of just removing them, this commit removes all of them and uses qualified names instead since they are in a header. PR-URL: #21634 Reviewed-By: Colin Ihrig <[email protected]>
1 parent b016745 commit e021ca2

File tree

1 file changed

+15
-27
lines changed

1 file changed

+15
-27
lines changed
 

‎src/spawn_sync.h

+15-27
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,6 @@
2929

3030
namespace node {
3131

32-
using v8::Array;
33-
using v8::Context;
34-
using v8::FunctionCallbackInfo;
35-
using v8::HandleScope;
36-
using v8::Integer;
37-
using v8::Isolate;
38-
using v8::Local;
39-
using v8::Null;
40-
using v8::Number;
41-
using v8::Object;
42-
using v8::String;
43-
using v8::Value;
4432

4533

4634
class SyncProcessOutputBuffer;
@@ -94,7 +82,7 @@ class SyncProcessStdioPipe {
9482
int Start();
9583
void Close();
9684

97-
Local<Object> GetOutputAsBuffer(Environment* env) const;
85+
v8::Local<v8::Object> GetOutputAsBuffer(Environment* env) const;
9886

9987
inline bool readable() const;
10088
inline bool writable() const;
@@ -151,10 +139,10 @@ class SyncProcessRunner {
151139
};
152140

153141
public:
154-
static void Initialize(Local<Object> target,
155-
Local<Value> unused,
156-
Local<Context> context);
157-
static void Spawn(const FunctionCallbackInfo<Value>& args);
142+
static void Initialize(v8::Local<v8::Object> target,
143+
v8::Local<v8::Value> unused,
144+
v8::Local<v8::Context> context);
145+
static void Spawn(const v8::FunctionCallbackInfo<v8::Value>& args);
158146

159147
private:
160148
friend class SyncProcessStdioPipe;
@@ -164,8 +152,8 @@ class SyncProcessRunner {
164152

165153
inline Environment* env() const;
166154

167-
Local<Object> Run(Local<Value> options);
168-
void TryInitializeAndRunLoop(Local<Value> options);
155+
v8::Local<v8::Object> Run(v8::Local<v8::Value> options);
156+
void TryInitializeAndRunLoop(v8::Local<v8::Value> options);
169157
void CloseHandlesAndDeleteLoop();
170158

171159
void CloseStdioPipes();
@@ -181,12 +169,12 @@ class SyncProcessRunner {
181169
void SetError(int error);
182170
void SetPipeError(int pipe_error);
183171

184-
Local<Object> BuildResultObject();
185-
Local<Array> BuildOutputArray();
172+
v8::Local<v8::Object> BuildResultObject();
173+
v8::Local<v8::Array> BuildOutputArray();
186174

187-
int ParseOptions(Local<Value> js_value);
188-
int ParseStdioOptions(Local<Value> js_value);
189-
int ParseStdioOption(int child_fd, Local<Object> js_stdio_option);
175+
int ParseOptions(v8::Local<v8::Value> js_value);
176+
int ParseStdioOptions(v8::Local<v8::Value> js_value);
177+
int ParseStdioOption(int child_fd, v8::Local<v8::Object> js_stdio_option);
190178

191179
inline int AddStdioIgnore(uint32_t child_fd);
192180
inline int AddStdioPipe(uint32_t child_fd,
@@ -195,9 +183,9 @@ class SyncProcessRunner {
195183
uv_buf_t input_buffer);
196184
inline int AddStdioInheritFD(uint32_t child_fd, int inherit_fd);
197185

198-
static bool IsSet(Local<Value> value);
199-
int CopyJsString(Local<Value> js_value, const char** target);
200-
int CopyJsStringArray(Local<Value> js_value, char** target);
186+
static bool IsSet(v8::Local<v8::Value> value);
187+
int CopyJsString(v8::Local<v8::Value> js_value, const char** target);
188+
int CopyJsStringArray(v8::Local<v8::Value> js_value, char** target);
201189

202190
static void ExitCallback(uv_process_t* handle,
203191
int64_t exit_status,

0 commit comments

Comments
 (0)
Please sign in to comment.