Skip to content

Commit e1967a2

Browse files
yhwangBethGriggs
authored andcommitted
build: skip cctest on Windows shared lib build
cctest depends on some internal APIs which don't declare `__declspec(dllexport)` and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows. Signed-off-by: Yihong Wang <[email protected]> PR-URL: #21228 Reviewed-By: Refael Ackermann <[email protected]>
1 parent 6352288 commit e1967a2

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

node.gyp

+4
Original file line numberDiff line numberDiff line change
@@ -961,6 +961,10 @@
961961
'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
962962
},
963963
}],
964+
# Skip cctest while building shared lib node for Windows
965+
[ 'OS=="win" and node_shared=="true"', {
966+
'type': 'none',
967+
}],
964968
],
965969
}
966970
], # end targets

vcbuild.bat

+1
Original file line numberDiff line numberDiff line change
@@ -474,6 +474,7 @@ if errorlevel 1 goto exit
474474
if "%test_args%"=="" goto test-v8
475475
if "%config%"=="Debug" set test_args=--mode=debug %test_args%
476476
if "%config%"=="Release" set test_args=--mode=release %test_args%
477+
if not exist %config%\cctest.exe goto run-test-py
477478
echo running 'cctest %cctest_args%'
478479
"%config%\cctest" %cctest_args%
479480
REM when building a static library there's no binary to run tests

0 commit comments

Comments
 (0)