test: refactor test-cluster-worker-isconnected.js

PR-URL: #13685
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: cjihrig

test/parallel/test-cluster-worker-isconnected.js

@@ -1,38 +1,30 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const cluster = require('cluster');
 const assert = require('assert');
 
 if (cluster.isMaster) {
   const worker = cluster.fork();
 
-  assert.ok(worker.isConnected(),
-            'isConnected() should return true as soon as the worker has ' +
-            'been created.');
+  assert.strictEqual(worker.isConnected(), true);
 
-  worker.on('disconnect', function() {
-    assert.ok(!worker.isConnected(),
-              'After a disconnect event has been emitted, ' +
-              'isConncted should return false');
-  });
+  worker.on('disconnect', common.mustCall(() => {
+    assert.strictEqual(worker.isConnected(), false);
+  }));
 
   worker.on('message', function(msg) {
     if (msg === 'readyToDisconnect') {
       worker.disconnect();
     }
   });
-
 } else {
-  assert.ok(cluster.worker.isConnected(),
-            'isConnected() should return true from within a worker at all ' +
-            'times.');
+  function assertNotConnected() {
+    assert.strictEqual(cluster.worker.isConnected(), false);
+  }
 
-  cluster.worker.process.on('disconnect', function() {
-    assert.ok(!cluster.worker.isConnected(),
-              'isConnected() should return false from within a worker ' +
-              'after its underlying process has been disconnected from ' +
-              'the master');
-  });
+  assert.strictEqual(cluster.worker.isConnected(), true);
+  cluster.worker.on('disconnect', common.mustCall(assertNotConnected));
+  cluster.worker.process.on('disconnect', common.mustCall(assertNotConnected));
 
   process.send('readyToDisconnect');
 }