Skip to content

Commit e254130

Browse files
ZYSzystargos
authored andcommitted
doc: tweak macOS-firewall note position
Move the macOS-firewall note to the end of "Building Node.js" and above "Running Tests". I think it's more reasonable when user prepare to build node step by step. Just read and build from top to end in case ignore the note. PR-URL: #22440 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 9d246f9 commit e254130

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

BUILDING.md

+11-11
Original file line numberDiff line numberDiff line change
@@ -135,17 +135,6 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and
135135
If the path to your build directory contains a space, the build will likely
136136
fail.
137137

138-
After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid
139-
popups asking to accept incoming network connections when running tests.
140-
141-
Running the following script on macOS will add the firewall rules for the
142-
executable `node` in the `out` directory and the symbolic `node` link in the
143-
project's root directory.
144-
145-
```console
146-
$ sudo ./tools/macos-firewall.sh
147-
```
148-
149138
On FreeBSD and OpenBSD, you may also need:
150139
* libexecinfo
151140

@@ -169,6 +158,17 @@ for more information.
169158
Note that the above requires that `python` resolve to Python 2.6 or 2.7
170159
and not a newer version.
171160

161+
After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid
162+
popups asking to accept incoming network connections when running tests.
163+
164+
Running the following script on macOS will add the firewall rules for the
165+
executable `node` in the `out` directory and the symbolic `node` link in the
166+
project's root directory.
167+
168+
```console
169+
$ sudo ./tools/macos-firewall.sh
170+
```
171+
172172
#### Running Tests
173173

174174
To verify the build:

0 commit comments

Comments
 (0)