Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit e340d28

Browse files
committedJun 5, 2017
http_parser: assert on incoming argument's type
Unchecked argument conversion in Parser::Consume crashes node in an slightly undesirable manner - 'unreachable code' in parser. Make sure we validate the incoming type at the earliest point. Refs: #12178
1 parent 917f86e commit e340d28

File tree

2 files changed

+29
-0
lines changed

2 files changed

+29
-0
lines changed
 

‎src/node_http_parser.cc

+1
Original file line numberDiff line numberDiff line change
@@ -496,6 +496,7 @@ class Parser : public AsyncWrap {
496496
static void Consume(const FunctionCallbackInfo<Value>& args) {
497497
Parser* parser;
498498
ASSIGN_OR_RETURN_UNWRAP(&parser, args.Holder());
499+
CHECK(args[0]->IsExternal());
499500
Local<External> stream_obj = args[0].As<External>();
500501
StreamBase* stream = static_cast<StreamBase*>(stream_obj->Value());
501502
CHECK_NE(stream, nullptr);
+28
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
'use strict';
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const http = require('http');
5+
const spawn = require('child_process').spawn;
6+
7+
if (process.argv[2] === 'child') {
8+
const server = http.createServer(common.mustCall((req, res) => {
9+
res.end('hello');
10+
}));
11+
12+
server.listen(0, common.mustCall((s) => {
13+
const rr = http.get(
14+
{ port: server.address().port },
15+
common.mustCall((d) => {
16+
// This bad input (0) should abort the parser and the process
17+
rr.parser.consume(0);
18+
server.close();
19+
}));
20+
}));
21+
} else {
22+
const child = spawn(process.execPath, [__filename, 'child'],
23+
{ stdio: 'inherit' });
24+
child.on('exit', common.mustCall((code, signal) => {
25+
assert(common.nodeProcessAborted(code, signal),
26+
'process should have aborted, but did not');
27+
}));
28+
}

0 commit comments

Comments
 (0)
Please sign in to comment.