Skip to content

Commit e397d19

Browse files
danbevMylesBorins
authored andcommitted
http2: remove unnecessary v8 qualified names
This commit removes v8 qualified identifiers that have using directives to be consistent with the rest of the code in node_http2.cc. PR-URL: #20420 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent b2bbc36 commit e397d19

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/node_http2.cc

+10-10
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Http2Options::Http2Options(Environment* env) {
110110
// a bit differently. For now, let's let nghttp2 take care of it.
111111
nghttp2_option_set_builtin_recv_extension_type(options_, NGHTTP2_ALTSVC);
112112

113-
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
113+
AliasedBuffer<uint32_t, Uint32Array>& buffer =
114114
env->http2_state()->options_buffer;
115115
uint32_t flags = buffer[IDX_OPTIONS_FLAGS];
116116

@@ -191,7 +191,7 @@ Http2Options::Http2Options(Environment* env) {
191191
}
192192

193193
void Http2Session::Http2Settings::Init() {
194-
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
194+
AliasedBuffer<uint32_t, Uint32Array>& buffer =
195195
env()->http2_state()->settings_buffer;
196196
uint32_t flags = buffer[IDX_SETTINGS_COUNT];
197197

@@ -270,7 +270,7 @@ Local<Value> Http2Session::Http2Settings::Pack() {
270270
void Http2Session::Http2Settings::Update(Environment* env,
271271
Http2Session* session,
272272
get_setting fn) {
273-
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
273+
AliasedBuffer<uint32_t, Uint32Array>& buffer =
274274
env->http2_state()->settings_buffer;
275275
buffer[IDX_SETTINGS_HEADER_TABLE_SIZE] =
276276
fn(**session, NGHTTP2_SETTINGS_HEADER_TABLE_SIZE);
@@ -288,7 +288,7 @@ void Http2Session::Http2Settings::Update(Environment* env,
288288

289289
// Initializes the shared TypedArray with the default settings values.
290290
void Http2Session::Http2Settings::RefreshDefaults(Environment* env) {
291-
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
291+
AliasedBuffer<uint32_t, Uint32Array>& buffer =
292292
env->http2_state()->settings_buffer;
293293

294294
buffer[IDX_SETTINGS_HEADER_TABLE_SIZE] =
@@ -505,7 +505,7 @@ Http2Session::~Http2Session() {
505505
}
506506

507507
inline bool HasHttp2Observer(Environment* env) {
508-
AliasedBuffer<uint32_t, v8::Uint32Array>& observers =
508+
AliasedBuffer<uint32_t, Uint32Array>& observers =
509509
env->performance_state()->observers;
510510
return observers[performance::NODE_PERFORMANCE_ENTRY_TYPE_HTTP2] != 0;
511511
}
@@ -522,7 +522,7 @@ void Http2Stream::EmitStatistics() {
522522
if (!HasHttp2Observer(env))
523523
return;
524524
HandleScope handle_scope(env->isolate());
525-
AliasedBuffer<double, v8::Float64Array>& buffer =
525+
AliasedBuffer<double, Float64Array>& buffer =
526526
env->http2_state()->stream_stats_buffer;
527527
buffer[IDX_STREAM_STATS_ID] = entry->id();
528528
if (entry->first_byte() != 0) {
@@ -561,7 +561,7 @@ void Http2Session::EmitStatistics() {
561561
if (!HasHttp2Observer(env))
562562
return;
563563
HandleScope handle_scope(env->isolate());
564-
AliasedBuffer<double, v8::Float64Array>& buffer =
564+
AliasedBuffer<double, Float64Array>& buffer =
565565
env->http2_state()->session_stats_buffer;
566566
buffer[IDX_SESSION_STATS_TYPE] = entry->type();
567567
buffer[IDX_SESSION_STATS_PINGRTT] = entry->ping_rtt() / 1e6;
@@ -690,7 +690,7 @@ ssize_t Http2Session::OnCallbackPadding(size_t frameLen,
690690
Local<Context> context = env()->context();
691691
Context::Scope context_scope(context);
692692

693-
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
693+
AliasedBuffer<uint32_t, Uint32Array>& buffer =
694694
env()->http2_state()->padding_buffer;
695695
buffer[PADDING_BUF_FRAME_LENGTH] = frameLen;
696696
buffer[PADDING_BUF_MAX_PAYLOAD_LENGTH] = maxPayloadLen;
@@ -2158,7 +2158,7 @@ void Http2Session::RefreshState(const FunctionCallbackInfo<Value>& args) {
21582158
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
21592159
DEBUG_HTTP2SESSION(session, "refreshing state");
21602160

2161-
AliasedBuffer<double, v8::Float64Array>& buffer =
2161+
AliasedBuffer<double, Float64Array>& buffer =
21622162
env->http2_state()->session_state_buffer;
21632163

21642164
nghttp2_session* s = **session;
@@ -2448,7 +2448,7 @@ void Http2Stream::RefreshState(const FunctionCallbackInfo<Value>& args) {
24482448

24492449
DEBUG_HTTP2STREAM(stream, "refreshing state");
24502450

2451-
AliasedBuffer<double, v8::Float64Array>& buffer =
2451+
AliasedBuffer<double, Float64Array>& buffer =
24522452
env->http2_state()->stream_state_buffer;
24532453

24542454
nghttp2_stream* str = **stream;

0 commit comments

Comments
 (0)