Skip to content

Commit e5d2a95

Browse files
danbevMyles Borins
authored and
Myles Borins
committed
src: remove out-of-date TODO comment
This commit attempts to fix one of the items in #4641, which was to remove a TODO the UDPWrap::OnSend function and share the code in that method with StreamWrap::AfterWrite. While looking into this addaleax pointed out that the implementations for these two functions have diverged since the original comment was added: $ git log --pretty=short -u -L 357,357:src/udp_wrap.cc $ git show cbd4033:src/udp_wrap.cc | grep -1 -A26 'UDPWrap::OnSend' git show cbd4033:src/stream_wrap.cc | grep -A27 'void StreamWrap::AfterWrite' Removing the TODO comment seems appropriate in this case. PR-URL: #9000 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent b4353e9 commit e5d2a95

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/udp_wrap.cc

-1
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,6 @@ void UDPWrap::RecvStop(const FunctionCallbackInfo<Value>& args) {
342342
}
343343

344344

345-
// TODO(bnoordhuis) share with StreamWrap::AfterWrite() in stream_wrap.cc
346345
void UDPWrap::OnSend(uv_udp_send_t* req, int status) {
347346
SendWrap* req_wrap = static_cast<SendWrap*>(req->data);
348347
if (req_wrap->have_callback()) {

0 commit comments

Comments
 (0)