Skip to content

Commit e61337d

Browse files
mhdawsonaddaleax
authored andcommitted
async_wrap: fix memory leak in AsyncResource
Reset the persistent that keeps the resource Object alive when the AsyncResource is being destroyed. Fixes: nodejs/node-addon-api#237 PR-URL: #20668 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 2a7c863 commit e61337d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/node.h

+1
Original file line numberDiff line numberDiff line change
@@ -714,6 +714,7 @@ class AsyncResource {
714714

715715
virtual ~AsyncResource() {
716716
EmitAsyncDestroy(isolate_, async_context_);
717+
resource_.Reset();
717718
}
718719

719720
v8::MaybeLocal<v8::Value> MakeCallback(

0 commit comments

Comments
 (0)