Skip to content

Commit e6bbc50

Browse files
committed
doc: improve the workflow to test release binaries
PR-URL: #45004 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 43677e5 commit e6bbc50

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

doc/contributing/releases.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -603,13 +603,14 @@ the build before moving forward. Use the following list as a baseline:
603603
must be in the expected updated version)
604604
* npm version (check it matches what we expect)
605605
* Run the test suite against the built binaries (optional)
606+
* Remember to use the proposal branch
607+
* Run `make build-addons` before running the tests
608+
* Remove `config.gypi` file
606609

607610
```console
608611
./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
609612
```
610613

611-
<sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup>
612-
613614
### 11. Tag and sign the release commit
614615

615616
Once you have produced builds that you're happy with, create a new tag. By

0 commit comments

Comments
 (0)