Skip to content

Commit e73d697

Browse files
rvaggMyles Borins
authored and
Myles Borins
committed
build: update signtool description, add url
PR-URL: #4011 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Alexis Campailla <[email protected]>
1 parent 5d3c64f commit e73d697

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

vcbuild.bat

+2-2
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ if "%target%" == "Clean" goto exit
186186
@rem Skip signing if the `nosign` option was specified.
187187
if defined nosign goto licensertf
188188

189-
signtool sign /a /d "node" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\node.exe
189+
signtool sign /a /d "Node.js" /du "https://nodejs.org" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\node.exe
190190
if errorlevel 1 echo Failed to sign exe&goto exit
191191

192192
:licensertf
@@ -206,7 +206,7 @@ msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /m /t:Clean,Build /p:PlatformToolset=%
206206
if errorlevel 1 goto exit
207207

208208
if defined nosign goto upload
209-
signtool sign /a /d "node" /t http://timestamp.globalsign.com/scripts/timestamp.dll node-v%FULLVERSION%-%target_arch%.msi
209+
signtool sign /a /d "Node.js" /du "https://nodejs.org" /t http://timestamp.globalsign.com/scripts/timestamp.dll node-v%FULLVERSION%-%target_arch%.msi
210210
if errorlevel 1 echo Failed to sign msi&goto exit
211211

212212
:upload

0 commit comments

Comments
 (0)