Skip to content

Commit eab5ef5

Browse files
joaocgreistargos
authored andcommitted
deps: make v8.h compatible with VS2015
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: #32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent d6e5dd5 commit eab5ef5

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.3',
39+
'v8_embedder_string': '-node.4',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-message.h

+4
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ class ScriptOriginOptions {
6060
*/
6161
class V8_EXPORT ScriptOrigin {
6262
public:
63+
#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
6364
V8_DEPRECATE_SOON("Use constructor with primitive C++ types")
65+
#endif
6466
ScriptOrigin(
6567
Local<Value> resource_name, Local<Integer> resource_line_offset,
6668
Local<Integer> resource_column_offset,
@@ -71,7 +73,9 @@ class V8_EXPORT ScriptOrigin {
7173
Local<Boolean> is_wasm = Local<Boolean>(),
7274
Local<Boolean> is_module = Local<Boolean>(),
7375
Local<PrimitiveArray> host_defined_options = Local<PrimitiveArray>());
76+
#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
7477
V8_DEPRECATE_SOON("Use constructor that takes an isolate")
78+
#endif
7579
explicit ScriptOrigin(
7680
Local<Value> resource_name, int resource_line_offset = 0,
7781
int resource_column_offset = 0,

0 commit comments

Comments
 (0)