Skip to content

Commit eb01214

Browse files
benjamingrcodebytere
authored andcommitted
events: use property, primordials
PR-URL: #33775 Fixes: #33773 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 1791d57 commit eb01214

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

lib/internal/event_target.js

+14-4
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const {
88
Set,
99
Symbol,
1010
NumberIsNaN,
11+
SymbolToStringTag,
1112
} = primordials;
1213

1314
const {
@@ -67,7 +68,6 @@ class Event {
6768
// isTrusted is special (LegacyUnforgeable)
6869
Object.defineProperty(this, 'isTrusted', {
6970
get() { return false; },
70-
set(ignoredValue) { return false; },
7171
enumerable: true,
7272
configurable: false
7373
});
@@ -132,10 +132,15 @@ class Event {
132132
stopPropagation() {
133133
this.#propagationStopped = true;
134134
}
135-
136-
get [Symbol.toStringTag]() { return 'Event'; }
137135
}
138136

137+
Object.defineProperty(Event.prototype, SymbolToStringTag, {
138+
writable: false,
139+
enumerable: false,
140+
configurable: true,
141+
value: 'Event',
142+
});
143+
139144
// The listeners for an EventTarget are maintained as a linked list.
140145
// Unfortunately, the way EventTarget is defined, listeners are accounted
141146
// using the tuple [handler,capture], and even if we don't actually make
@@ -305,14 +310,19 @@ class EventTarget {
305310

306311
return `${name} ${inspect({}, opts)}`;
307312
}
308-
get [Symbol.toStringTag]() { return 'EventTarget'; }
309313
}
310314

311315
Object.defineProperties(EventTarget.prototype, {
312316
addEventListener: { enumerable: true },
313317
removeEventListener: { enumerable: true },
314318
dispatchEvent: { enumerable: true }
315319
});
320+
Object.defineProperty(EventTarget.prototype, SymbolToStringTag, {
321+
writable: false,
322+
enumerable: false,
323+
configurable: true,
324+
value: 'EventTarget',
325+
});
316326

317327
class NodeEventTarget extends EventTarget {
318328
static defaultMaxListeners = 10;

0 commit comments

Comments
 (0)