Skip to content

Commit eb8f5ce

Browse files
richardlautargos
authored andcommitted
test: use .test domain for not found address
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: #38286 Refs: #38282 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent d3bd4b4 commit eb8f5ce

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/common/internet.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const addresses = {
2424
MX_HOST: 'nodejs.org',
2525
// On some systems, .invalid returns a server failure/try again rather than
2626
// record not found. Use this to guarantee record not found.
27-
NOT_FOUND: 'come.on.fhqwhgads',
27+
NOT_FOUND: 'come.on.fhqwhgads.test',
2828
// A host with SRV records registered
2929
SRV_HOST: '_jabber._tcp.google.com',
3030
// A host with PTR records registered

0 commit comments

Comments
 (0)