Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ec459ee

Browse files
indutnyrvagg
authored andcommittedFeb 27, 2016
github: add issue and pull request templates
Fix: #5246 PR-URL: #5291 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Steven R. Loomis <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brian White <[email protected]>
1 parent 991f82b commit ec459ee

File tree

2 files changed

+38
-0
lines changed

2 files changed

+38
-0
lines changed
 

‎.github/ISSUE_TEMPLATE.md

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
_Thanks for wanting to report an issue you've found in Node.js. Please delete
2+
this text and fill in the template below. If unsure about something, just do as
3+
best as you're able._
4+
5+
_Note that it will be much easier for us to fix the issue if a test case that
6+
reproduces the problem is provided. Ideally this test case should not have any
7+
external dependencies. We understand that it is not always possible to reduce
8+
your code to a small test case, but we would appreciate to have as much data as
9+
possible. Thank you!_
10+
11+
* **Version**: _output of `node -v`_
12+
* **Platform**: _either `uname -a` output, or if Windows, version and 32-bit or
13+
64-bit_
14+
* **Subsystem**: _optional. if known - please specify affected core module name_

‎.github/PULL_REQUEST_TEMPLATE.md

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
### Description of change
2+
3+
_Please provide a description of the change here._
4+
5+
### Pull Request check-list
6+
7+
_Please make sure to review and check all of these items:_
8+
9+
- [ ] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with
10+
this change (including linting)?
11+
- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0]?
12+
- [ ] If this change fixes a bug (or a performance problem), is a regression
13+
test (or a benchmark) included?
14+
- [ ] Is a documentation update included (if this change modifies
15+
existing APIs, or introduces new ones)?
16+
17+
_NOTE: these things are not required to open a PR and can be done afterwards /
18+
while the PR is open._
19+
20+
### Affected core subsystem(s)
21+
22+
_Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)_
23+
24+
[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit

0 commit comments

Comments
 (0)
Please sign in to comment.