Skip to content

Commit ed81497

Browse files
ssbrewsterMylesBorins
authored andcommitted
test: use no-save and no-package-lock flags
Use these flags when running make coverage so that a package-lock.json file is not generated and npm does not attempt to save the deps to a non-existent package.json file. PR-URL: #15196 Refs: https://github.com/nodejs/node/pull/15190/files#r136932786 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 0814a71 commit ed81497

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Makefile

+3-2
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,9 @@ coverage: coverage-test
139139
coverage-build: all
140140
mkdir -p node_modules
141141
if [ ! -d node_modules/istanbul-merge ]; then \
142-
$(NODE) ./deps/npm install istanbul-merge; fi
143-
if [ ! -d node_modules/nyc ]; then $(NODE) ./deps/npm install nyc; fi
142+
$(NODE) ./deps/npm install istanbul-merge --no-save --no-package-lock; fi
143+
if [ ! -d node_modules/nyc ]; then \
144+
$(NODE) ./deps/npm install nyc --no-save --no-package-lock; fi
144145
if [ ! -d gcovr ]; then git clone --depth=1 \
145146
--single-branch git://github.com/gcovr/gcovr.git; fi
146147
if [ ! -d testing ]; then git clone --depth=1 \

0 commit comments

Comments
 (0)