Skip to content

Commit ed874e4

Browse files
danbevtargos
authored andcommitted
build: use echo command instead of shell comments
Currently, there are a few recipes where comments are indented and being passed to the shell. This commit updates these comments to use the echo command instead, which is the more common approach used in other recipes in the makefile. PR-URL: #22293 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
1 parent 149c209 commit ed874e4

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

Makefile

+9-9
Original file line numberDiff line numberDiff line change
@@ -266,26 +266,26 @@ jstest: build-addons build-addons-napi ## Runs addon tests and JS tests
266266
.PHONY: test
267267
# This does not run tests of third-party libraries inside deps.
268268
test: all ## Runs default tests, linters, and builds docs.
269-
# Build the addons before running the tests so the test results
270-
# can be displayed together
269+
@echo "Build the addons before running the tests so the test results"
270+
@echo "can be displayed together"
271271
$(MAKE) -s build-addons
272272
$(MAKE) -s build-addons-napi
273273
$(MAKE) -s cctest
274274
$(MAKE) -s jstest
275275

276276
.PHONY: test-only
277277
test-only: all ## For a quick test, does not run linter or build docs.
278-
# Build the addons before running the tests so the test results
279-
# can be displayed together
278+
@echo "Build the addons before running the tests so the test results"
279+
@echo "can be displayed together"
280280
$(MAKE) build-addons
281281
$(MAKE) build-addons-napi
282282
$(MAKE) cctest
283283
$(MAKE) jstest
284284

285285
# Used by `make coverage-test`
286286
test-cov: all
287-
# Build the addons before running the tests so the test results
288-
# can be displayed together
287+
@echo "Build the addons before running the tests so the test results"
288+
@echo "can be displayed together"
289289
$(MAKE) build-addons
290290
$(MAKE) build-addons-napi
291291
# $(MAKE) cctest
@@ -399,7 +399,7 @@ build-addons-napi: | $(NODE_EXE) test/addons-napi/.buildstamp
399399

400400
.PHONY: clear-stalled
401401
clear-stalled:
402-
# Clean up any leftover processes but don't error if found.
402+
@echo "Clean up any leftover processes but don't error if found."
403403
ps awwx | grep Release/node | grep -v grep | cat
404404
@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
405405
if [ "$${PS_OUT}" ]; then \
@@ -437,7 +437,7 @@ test-ci-js: | clear-stalled
437437
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
438438
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
439439
$(TEST_CI_ARGS) $(CI_JS_SUITES)
440-
# Clean up any leftover processes, error if found.
440+
@echo "Clean up any leftover processes, error if found."
441441
ps awwx | grep Release/node | grep -v grep | cat
442442
@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
443443
if [ "$${PS_OUT}" ]; then \
@@ -452,7 +452,7 @@ test-ci: | clear-stalled build-addons build-addons-napi doc-only
452452
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
453453
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
454454
$(TEST_CI_ARGS) $(CI_JS_SUITES) $(CI_NATIVE_SUITES) $(CI_DOC)
455-
# Clean up any leftover processes, error if found.
455+
@echo "Clean up any leftover processes, error if found."
456456
ps awwx | grep Release/node | grep -v grep | cat
457457
@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
458458
if [ "$${PS_OUT}" ]; then \

0 commit comments

Comments
 (0)