Skip to content

Commit ee65e44

Browse files
aduh95targos
authored andcommittedNov 11, 2023
esm: use import attributes instead of import assertions
The old import assertions proposal has been renamed to "import attributes" with the follwing major changes: 1. The keyword is now `with` instead of `assert`. 2. Unknown assertions cause an error rather than being ignored, This commit updates the documentation to encourage folks to use the new syntax, and add aliases for module customization hooks. PR-URL: #50140 Fixes: #50134 Refs: v8/v8@159c82c Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
1 parent 6547bd2 commit ee65e44

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+472
-353
lines changed
 

‎.eslintignore

+2
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,7 @@ tools/github_reporter
99
benchmark/tmp
1010
benchmark/fixtures
1111
doc/**/*.js
12+
doc/changelogs/CHANGELOG_v1*.md
13+
!doc/changelogs/CHANGELOG_v18.md
1214
!doc/api_assets/*.js
1315
!.eslintrc.js

‎.eslintrc.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const hacks = [
1818
'eslint-plugin-jsdoc',
1919
'eslint-plugin-markdown',
2020
'@babel/eslint-parser',
21-
'@babel/plugin-syntax-import-assertions',
21+
'@babel/plugin-syntax-import-attributes',
2222
];
2323
Module._findPath = (request, paths, isMain) => {
2424
const r = ModuleFindPath(request, paths, isMain);
@@ -44,7 +44,7 @@ module.exports = {
4444
parserOptions: {
4545
babelOptions: {
4646
plugins: [
47-
Module._findPath('@babel/plugin-syntax-import-assertions'),
47+
Module._findPath('@babel/plugin-syntax-import-attributes'),
4848
],
4949
},
5050
requireConfigFile: false,

0 commit comments

Comments
 (0)
Please sign in to comment.