File tree 2 files changed +3
-3
lines changed
2 files changed +3
-3
lines changed Original file line number Diff line number Diff line change @@ -171,7 +171,7 @@ agenda.
171
171
### Waiting for Approvals
172
172
173
173
Before landing pull requests, sufficient time should be left for input
174
- from other Collaborators. In general, leave at least 72 hours to account for
174
+ from other Collaborators. In general, leave at least 48 hours to account for
175
175
international time differences and work schedules. However, certain types of
176
176
pull requests can be fast-tracked and may be landed after a shorter delay. For
177
177
example:
Original file line number Diff line number Diff line change @@ -138,7 +138,7 @@ onboarding session.
138
138
* There is a minimum waiting time which we try to respect for non-trivial
139
139
changes so that people who may have important input in such a distributed
140
140
project are able to respond.
141
- * For non-trivial changes, leave the pull request open for at least 72 hours.
141
+ * For non-trivial changes, leave the pull request open for at least 48 hours.
142
142
* If a pull request is abandoned, check if they'd mind if you took it over
143
143
(especially if it just has nits left).
144
144
* Approving a change
@@ -214,7 +214,7 @@ needs to be pointed out separately during the onboarding.
214
214
* Run CI on the PR. Because the PR does not affect any code, use the
215
215
` node-test-pull-request-lite-pipeline ` CI task.
216
216
* After one or two approvals, land the PR (PRs of this type do not need to wait
217
- for 72 hours to land).
217
+ for 48 hours to land).
218
218
* Be sure to add the ` PR-URL: <full-pr-url> ` and appropriate ` Reviewed-By: `
219
219
metadata.
220
220
* [ ` node-core-utils ` ] [ ] automates the generation of metadata and the landing
You can’t perform that action at this time.
0 commit comments