Skip to content

Commit ef0f7e6

Browse files
Trotttargos
authored andcommitted
doc: shorten pull request wait time to 48 hours
Currently, we have a 72 rule for how many hours a pull request should be left open at a minimum. Reduce that time to 48 hours. PR-URL: #23082 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
1 parent 5b76313 commit ef0f7e6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

COLLABORATOR_GUIDE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ agenda.
171171
### Waiting for Approvals
172172

173173
Before landing pull requests, sufficient time should be left for input
174-
from other Collaborators. In general, leave at least 72 hours to account for
174+
from other Collaborators. In general, leave at least 48 hours to account for
175175
international time differences and work schedules. However, certain types of
176176
pull requests can be fast-tracked and may be landed after a shorter delay. For
177177
example:

doc/onboarding.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ onboarding session.
138138
* There is a minimum waiting time which we try to respect for non-trivial
139139
changes so that people who may have important input in such a distributed
140140
project are able to respond.
141-
* For non-trivial changes, leave the pull request open for at least 72 hours.
141+
* For non-trivial changes, leave the pull request open for at least 48 hours.
142142
* If a pull request is abandoned, check if they'd mind if you took it over
143143
(especially if it just has nits left).
144144
* Approving a change
@@ -214,7 +214,7 @@ needs to be pointed out separately during the onboarding.
214214
* Run CI on the PR. Because the PR does not affect any code, use the
215215
`node-test-pull-request-lite-pipeline` CI task.
216216
* After one or two approvals, land the PR (PRs of this type do not need to wait
217-
for 72 hours to land).
217+
for 48 hours to land).
218218
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
219219
metadata.
220220
* [`node-core-utils`][] automates the generation of metadata and the landing

0 commit comments

Comments
 (0)