Skip to content

Commit efa19bd

Browse files
emilyavivarvagg
authored andcommitted
doc: add final full stop in CONTRIBUTING.md
PR-URL: #3576 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent cbd358c commit efa19bd

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

CONTRIBUTING.md

+14-14
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,21 @@ and built upon.
4545
The rules for the master branch are less strict; consult the
4646
[stability index](./doc/api/documentation.markdown#stability-index) for details.
4747

48-
In a nutshell, modules are at varying levels of API stability. Bug fixes are
48+
In a nutshell, modules are at varying levels of API stability. Bug fixes are
4949
always welcome but API or behavioral changes to modules at stability level 3
5050
(Locked) are off-limits.
5151

5252
#### Dependencies
5353

5454
Node.js has several bundled dependencies in the *deps/* and the *tools/*
55-
directories that are not part of the project proper. Any changes to files
55+
directories that are not part of the project proper. Any changes to files
5656
in those directories or its subdirectories should be sent to their respective
57-
projects. Do not send your patch to us, we cannot accept it.
57+
projects. Do not send your patch to us, we cannot accept it.
5858

5959
In case of doubt, open an issue in the
6060
[issue tracker](https://github.com/nodejs/node/issues/) or contact one of the
6161
[project Collaborators](https://github.com/nodejs/node/#current-project-team-members).
62-
([IRC](http://webchat.freenode.net/?channels=io.js) is often the best medium.) Especially do so if you plan to work on something big. Nothing is more
62+
([IRC](http://webchat.freenode.net/?channels=io.js) is often the best medium.) Especially do so if you plan to work on something big. Nothing is more
6363
frustrating than seeing your hard work go to waste because your vision
6464
does not align with the project team.
6565

@@ -81,8 +81,8 @@ $ git config --global user.name "J. Random User"
8181
$ git config --global user.email "[email protected]"
8282
```
8383

84-
Writing good commit logs is important. A commit log should describe what
85-
changed and why. Follow these guidelines when writing one:
84+
Writing good commit logs is important. A commit log should describe what
85+
changed and why. Follow these guidelines when writing one:
8686

8787
1. The first line should be 50 characters or less and contain a short
8888
description of the change prefixed with the name of the changed
@@ -124,15 +124,15 @@ $ git rebase upstream/master
124124

125125
### Step 5: Test
126126

127-
Bug fixes and features **should come with tests**. Add your tests in the
128-
test/parallel/ directory. Look at other tests to see how they should be
127+
Bug fixes and features **should come with tests**. Add your tests in the
128+
test/parallel/ directory. Look at other tests to see how they should be
129129
structured (license boilerplate, common includes, etc.).
130130

131131
```text
132132
$ ./configure && make -j8 test
133133
```
134134

135-
Make sure the linter is happy and that all tests pass. Please, do not submit
135+
Make sure the linter is happy and that all tests pass. Please, do not submit
136136
patches that fail either check.
137137

138138
If you are updating tests and just want to run a single test to check it, you
@@ -160,9 +160,9 @@ $ git push origin my-feature-branch
160160
Go to https://github.com/yourusername/node and select your feature branch.
161161
Click the 'Pull Request' button and fill out the form.
162162

163-
Pull requests are usually reviewed within a few days. If there are comments
163+
Pull requests are usually reviewed within a few days. If there are comments
164164
to address, apply your changes in a separate commit and push that to your
165-
feature branch. Post a comment in the pull request afterwards; GitHub does
165+
feature branch. Post a comment in the pull request afterwards; GitHub does
166166
not send out notifications when you add commits.
167167

168168

@@ -201,7 +201,7 @@ CoC](http://www.rust-lang.org/conduct.html).
201201
* Please keep unstructured critique to a minimum. If you have solid
202202
ideas you want to experiment with, make a fork and see how it works.
203203
* We will exclude you from interaction if you insult, demean or harass
204-
anyone. That is not welcome behavior. We interpret the term
204+
anyone. That is not welcome behavior. We interpret the term
205205
"harassment" as including the definition in the [Citizen Code of
206206
Conduct](http://citizencodeofconduct.org/); if you have any lack of
207207
clarity about what might be included in that concept, please read
@@ -211,11 +211,11 @@ CoC](http://www.rust-lang.org/conduct.html).
211211
you feel you have been or are being harassed or made uncomfortable
212212
by a community member, please contact one of the channel ops or any
213213
of the TC members immediately with a capture (log, photo, email) of
214-
the harassment if possible. Whether you're a regular contributor or
214+
the harassment if possible. Whether you're a regular contributor or
215215
a newcomer, we care about making this community a safe place for you
216216
and we've got your back.
217217
* Likewise any spamming, trolling, flaming, baiting or other
218218
attention-stealing behavior is not welcome.
219219
* Avoid the use of personal pronouns in code comments or
220220
documentation. There is no need to address persons when explaining
221-
code (e.g. "When the developer")
221+
code (e.g. "When the developer").

0 commit comments

Comments
 (0)