Skip to content

Commit f01183c

Browse files
Benjamin Kitargos
Benjamin Ki
authored andcommitted
test: move dgram invalid host test to internet tests
This moves a dgram test from `parallel` to `internet` because it relies on a DNS request. In certain cases, ISPs hijack invalid IETF-reserved invalid names which causes a false negative failure. Fixes: #27341 PR-URL: #27565 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent ae8b64d commit f01183c

File tree

2 files changed

+23
-12
lines changed

2 files changed

+23
-12
lines changed

test/internet/test-dgram-connect.js

+21
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
const { addresses } = require('../common/internet');
5+
const assert = require('assert');
6+
const dgram = require('dgram');
7+
8+
const PORT = 12345;
9+
10+
const client = dgram.createSocket('udp4');
11+
client.connect(PORT, addresses.INVALID_HOST, common.mustCall((err) => {
12+
assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN');
13+
14+
client.once('error', common.mustCall((err) => {
15+
assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN');
16+
client.once('connect', common.mustCall(() => client.close()));
17+
client.connect(PORT);
18+
}));
19+
20+
client.connect(PORT, addresses.INVALID_HOST);
21+
}));

test/parallel/test-dgram-connect.js

+2-12
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

33
const common = require('../common');
4-
const { addresses } = require('../common/internet');
54
const assert = require('assert');
65
const dgram = require('dgram');
76

@@ -36,17 +35,8 @@ client.connect(PORT, common.mustCall(() => {
3635
code: 'ERR_SOCKET_DGRAM_NOT_CONNECTED'
3736
});
3837

39-
client.connect(PORT, addresses.INVALID_HOST, common.mustCall((err) => {
40-
assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN');
41-
42-
client.once('error', common.mustCall((err) => {
43-
assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN');
44-
client.once('connect', common.mustCall(() => client.close()));
45-
client.connect(PORT);
46-
}));
47-
48-
client.connect(PORT, addresses.INVALID_HOST);
49-
}));
38+
client.once('connect', common.mustCall(() => client.close()));
39+
client.connect(PORT);
5040
}));
5141

5242
assert.throws(() => {

0 commit comments

Comments
 (0)