fs: ensure readdir() callback is only called once

This commit ensures that the readdir() callback can only be
called once when the withFileTypes parameter is supplied.

PR-URL: #22793
Fixes: #22778
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>

Author: cjihrig

lib/internal/fs/utils.js

@@ -10,6 +10,7 @@ const {
   ERR_OUT_OF_RANGE
 } = require('internal/errors').codes;
 const { isUint8Array, isArrayBufferView } = require('internal/util/types');
+const { once } = require('internal/util');
 const pathModule = require('path');
 const util = require('util');
 const kType = Symbol('type');
@@ -123,6 +124,7 @@ function getDirents(path, [names, types], callback) {
   if (typeof callback == 'function') {
     const len = names.length;
     let toFinish = 0;
+    callback = once(callback);
     for (i = 0; i < len; i++) {
       const type = types[i];
       if (type === UV_DIRENT_UNKNOWN) {

lib/internal/streams/pipeline.js

@@ -5,20 +5,12 @@
 
 let eos;
 
+const { once } = require('internal/util');
 const {
   ERR_MISSING_ARGS,
   ERR_STREAM_DESTROYED
 } = require('internal/errors').codes;
 
-function once(callback) {
-  let called = false;
-  return function(err) {
-    if (called) return;
-    called = true;
-    callback(err);
-  };
-}
-
 function noop(err) {
   // Rethrow the error if it exists to avoid swallowing it
   if (err) throw err;

lib/internal/util.js

@@ -364,6 +364,15 @@ function isInsideNodeModules() {
   return false;
 }
 
+function once(callback) {
+  let called = false;
+  return function(...args) {
+    if (called) return;
+    called = true;
+    callback(...args);
+  };
+}
+
 module.exports = {
   assertCrypto,
   cachedResult,
@@ -380,6 +389,7 @@ module.exports = {
   join,
   normalizeEncoding,
   objectToString,
+  once,
   promisify,
   spliceOne,
   removeColors,