Skip to content

Commit f118f7a

Browse files
addaleaxjasnell
authored andcommitted
v8: backport header diff from 2e4a68733803
Backport API-incompatible changes from 2e4a68733803 (“[v8] v8::StackTrace::AsArray returns correct array”). Ref: https://codereview.chromium.org/2806373005 Ref: https://github.com/v8/v8/2e4a68733803 PR-URL: #12875 Reviewed-By: James M Snell <[email protected]>
1 parent a947cf9 commit f118f7a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

deps/v8/include/v8.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -1511,6 +1511,8 @@ class V8_EXPORT StackTrace {
15111511
/**
15121512
* Flags that determine what information is placed captured for each
15131513
* StackFrame when grabbing the current stack trace.
1514+
* Note: these options are deprecated and we always collect all available
1515+
* information (kDetailed).
15141516
*/
15151517
enum StackTraceOptions {
15161518
kLineNumber = 1,
@@ -1539,7 +1541,7 @@ class V8_EXPORT StackTrace {
15391541
/**
15401542
* Returns StackTrace as a v8::Array that contains StackFrame objects.
15411543
*/
1542-
Local<Array> AsArray();
1544+
V8_DEPRECATED("Use native API instead", Local<Array> AsArray());
15431545

15441546
/**
15451547
* Grab a snapshot of the current JavaScript execution stack.
@@ -1549,9 +1551,7 @@ class V8_EXPORT StackTrace {
15491551
* StackFrame.
15501552
*/
15511553
static Local<StackTrace> CurrentStackTrace(
1552-
Isolate* isolate,
1553-
int frame_limit,
1554-
StackTraceOptions options = kOverview);
1554+
Isolate* isolate, int frame_limit, StackTraceOptions options = kDetailed);
15551555
};
15561556

15571557

0 commit comments

Comments
 (0)