Skip to content

Commit f11d4a1

Browse files
weeweyjasnell
authored andcommitted
test: use common.mustCall in test-https-strict
PR-URL: #12668 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 972bfe1 commit f11d4a1

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

test/parallel/test-https-strict.js

+2-8
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@ server2.listen(0, listening());
9191
server3.listen(0, listening());
9292

9393
const responseErrors = {};
94-
let expectResponseCount = 0;
95-
let responseCount = 0;
9694
let pending = 0;
9795

9896

@@ -147,17 +145,14 @@ function makeReq(path, port, error, host, ca) {
147145
options.headers = { host: host };
148146
}
149147
const req = https.get(options);
150-
expectResponseCount++;
151148
const server = port === server1.address().port ? server1 :
152149
port === server2.address().port ? server2 :
153150
port === server3.address().port ? server3 :
154151
null;
155-
156152
if (!server) throw new Error('invalid port: ' + port);
157153
server.expectCount++;
158154

159-
req.on('response', (res) => {
160-
responseCount++;
155+
req.on('response', common.mustCall((res) => {
161156
assert.strictEqual(res.connection.authorizationError, error);
162157
responseErrors[path] = res.connection.authorizationError;
163158
pending--;
@@ -167,7 +162,7 @@ function makeReq(path, port, error, host, ca) {
167162
server3.close();
168163
}
169164
res.resume();
170-
});
165+
}));
171166
}
172167

173168
function allListening() {
@@ -220,5 +215,4 @@ process.on('exit', () => {
220215
assert.strictEqual(server1.requests.length, server1.expectCount);
221216
assert.strictEqual(server2.requests.length, server2.expectCount);
222217
assert.strictEqual(server3.requests.length, server3.expectCount);
223-
assert.strictEqual(responseCount, expectResponseCount);
224218
});

0 commit comments

Comments
 (0)