Skip to content

Commit f1569f3

Browse files
DanielSchuechtargos
authored andcommitted
http2: core.js replace var with let
const has to be used in for in loop PR-URL: #30403 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 0000859 commit f1569f3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/internal/http2/core.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ function onOrigin(origins) {
590590
if (!session.encrypted || session.destroyed)
591591
return undefined;
592592
const originSet = initOriginSet(session);
593-
for (var n = 0; n < origins.length; n++)
593+
for (let n = 0; n < origins.length; n++)
594594
originSet.add(origins[n]);
595595
session.emit('origin', origins);
596596
}
@@ -1518,7 +1518,7 @@ class ServerHttp2Session extends Http2Session {
15181518
let arr = '';
15191519
let len = 0;
15201520
const count = origins.length;
1521-
for (var i = 0; i < count; i++) {
1521+
for (let i = 0; i < count; i++) {
15221522
let origin = origins[i];
15231523
if (typeof origin === 'string') {
15241524
origin = (new URL(origin)).origin;
@@ -2150,7 +2150,7 @@ function processHeaders(oldHeaders) {
21502150
if (oldHeaders !== null && oldHeaders !== undefined) {
21512151
const hop = hasOwnProperty.bind(oldHeaders);
21522152
// This loop is here for performance reason. Do not change.
2153-
for (var key in oldHeaders) {
2153+
for (const key in oldHeaders) {
21542154
if (hop(key)) {
21552155
headers[key] = oldHeaders[key];
21562156
}

0 commit comments

Comments
 (0)