Skip to content

Commit f21fbee

Browse files
nickiesxa
authored andcommitted
test: update V8 trace events test expectations
The event "V8.GCScavenger" is soon to be deprecated. Most of V8 trace events are either behind flags and disabled by default, or are emitted infrequently. Instead of replacing "V8.GCScavenger" with some other random event, this patch updates the tests to check that there is some event in the category "v8" whose name starts with "V8.". PR-URL: #42120 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent ce86fc3 commit f21fbee

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/parallel/test-trace-events-all.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ proc.once('exit', common.mustCall(() => {
2727
return false;
2828
if (trace.cat !== 'v8')
2929
return false;
30-
if (trace.name !== 'V8.GCScavenger')
30+
if (!trace.name.startsWith('V8.'))
3131
return false;
3232
return true;
3333
}));

test/parallel/test-trace-events-v8.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ proc.once('exit', common.mustCall(() => {
2929
return false;
3030
if (trace.cat !== 'v8')
3131
return false;
32-
if (trace.name !== 'V8.GCScavenger')
32+
if (!trace.name.startsWith('V8.'))
3333
return false;
3434
return true;
3535
}));

0 commit comments

Comments
 (0)