Skip to content

Commit f29c5d6

Browse files
indutnyrvagg
authored andcommitted
configure: v8_use_snapshot should be true
`v8_use_snapshot` should be either `true` or `false`, not 1 or 0. PR-URL: #3962 Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent b81b45d commit f29c5d6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

configure

+1-1
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,7 @@ def configure_v8(o):
777777
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
778778
o['variables']['v8_optimized_debug'] = 0 # Compile with -O0 in debug builds.
779779
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
780-
o['variables']['v8_use_snapshot'] = 0 if options.without_snapshot else 1
780+
o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true'
781781

782782
def configure_openssl(o):
783783
o['variables']['node_use_openssl'] = b(not options.without_ssl)

0 commit comments

Comments
 (0)