Skip to content

Commit f3b5cc0

Browse files
committed
meta: travis: run compilation jobs first
even though jobs can run in parallel they start in declaration order * this patch makes "compiles >> no lint" in terms of precedence PR-URL: #27205 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent a38e9c4 commit f3b5cc0

File tree

1 file changed

+21
-20
lines changed

1 file changed

+21
-20
lines changed

.travis.yml

+21-20
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,8 @@ dist: xenial
99
language: cpp
1010
jobs:
1111
include:
12-
- stage: "Lint and Compile"
13-
name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>"
14-
if: type = pull_request
15-
language: node_js
16-
node_js: "node"
17-
script:
18-
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
19-
bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
20-
fi
21-
22-
- name: "Linter"
23-
language: node_js
24-
node_js: "node"
25-
install:
26-
- pyenv global 2.7.15
27-
- make lint-py-build || true
28-
script:
29-
- NODE=$(which node) make lint lint-py
30-
31-
- name: "Compile V8"
12+
- stage: "Compile"
13+
name: "Compile V8"
3214
cache: ccache
3315
addons:
3416
apt:
@@ -58,6 +40,7 @@ jobs:
5840
- cp out/Release/node /home/travis/.ccache
5941
- cp out/Release/cctest /home/travis/.ccache
6042

43+
- pyenv global 2.7.15
6144
- stage: "Tests"
6245
name: "Test JS Suites"
6346
cache: ccache
@@ -85,3 +68,21 @@ jobs:
8568
- out/Release/cctest
8669
- make -j1 V=1 test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
8770
- python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare addons js-native-api node-api
71+
72+
- name: "Linter"
73+
language: node_js
74+
node_js: "node"
75+
install:
76+
- pyenv global 2.7.15
77+
- make lint-py-build || true
78+
script:
79+
- NODE=$(which node) make lint lint-py
80+
81+
- name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>"
82+
if: type = pull_request
83+
language: node_js
84+
node_js: "node"
85+
script:
86+
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
87+
bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
88+
fi

0 commit comments

Comments
 (0)