Skip to content

Commit f556b43

Browse files
bnoordhuisMylesBorins
authored andcommitted
build: add --enable-d8 configure option
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
1 parent f43f965 commit f556b43

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

configure

+7
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,11 @@ parser.add_option('--release-urlbase',
223223
'`sourceUrl` and `headersUrl`. When compiling a release build, this '
224224
'will default to https://nodejs.org/download/release/')
225225

226+
parser.add_option('--enable-d8',
227+
action='store_true',
228+
dest='enable_d8',
229+
help=optparse.SUPPRESS_HELP) # Unsupported, undocumented.
230+
226231
parser.add_option('--v8-options',
227232
action='store',
228233
dest='v8_options',
@@ -804,6 +809,8 @@ def configure_v8(o):
804809
o['variables']['v8_optimized_debug'] = 0 # Compile with -O0 in debug builds.
805810
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
806811
o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true'
812+
o['variables']['node_enable_d8'] = b(options.enable_d8)
813+
807814

808815
def configure_openssl(o):
809816
o['variables']['node_use_openssl'] = b(not options.without_ssl)

node.gyp

+3
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,9 @@
209209

210210

211211
'conditions': [
212+
[ 'node_enable_d8=="true"', {
213+
'dependencies': [ 'deps/v8/src/d8.gyp:d8' ],
214+
}],
212215
[ 'node_tag!=""', {
213216
'defines': [ 'NODE_TAG="<(node_tag)"' ],
214217
}],

0 commit comments

Comments
 (0)