Skip to content

Commit f5e8342

Browse files
hacke2addaleax
authored andcommitted
test: improve regexps for error checking
test/parallel/test-catpto-random.js contains an object called errorMesssage that contains regular expressions.They are only partially matching regular expressions. Make them match the entire error message. PR-URL: #14271 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent 337a865 commit f5e8342

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

test/parallel/test-crypto-random.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,12 @@ const expectedErrorRegexp = /^TypeError: size must be a number >= 0$/;
140140
new Uint8Array(new Array(10).fill(0))
141141
];
142142
const errMessages = {
143-
offsetNotNumber: /offset must be a number/,
144-
offsetOutOfRange: /offset out of range/,
145-
offsetNotUInt32: /offset must be a uint32/,
146-
sizeNotNumber: /size must be a number/,
147-
sizeNotUInt32: /size must be a uint32/,
148-
bufferTooSmall: /buffer too small/,
143+
offsetNotNumber: /^TypeError: offset must be a number$/,
144+
offsetOutOfRange: /^RangeError: offset out of range$/,
145+
offsetNotUInt32: /^TypeError: offset must be a uint32$/,
146+
sizeNotNumber: /^TypeError: size must be a number$/,
147+
sizeNotUInt32: /^TypeError: size must be a uint32$/,
148+
bufferTooSmall: /^RangeError: buffer too small$/,
149149
};
150150

151151
for (const buf of bufs) {

0 commit comments

Comments
 (0)