Skip to content

Commit f6642e9

Browse files
preveen-stacktargos
authored andcommitted
src: elevate namespaces in node_worker.cc
In node_worker.cc there are few instances where v8 namespaced entitites are used inline. Elevate them with `using` semantics. PR-URL: #27568 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 62fe342 commit f6642e9

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/node_worker.cc

+8-6
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#include <vector>
1717

1818
using node::options_parser::kDisallowedInEnvironment;
19+
using v8::Array;
1920
using v8::ArrayBuffer;
2021
using v8::Boolean;
2122
using v8::Context;
@@ -27,6 +28,7 @@ using v8::Integer;
2728
using v8::Isolate;
2829
using v8::Local;
2930
using v8::Locker;
31+
using v8::MaybeLocal;
3032
using v8::Number;
3133
using v8::Object;
3234
using v8::SealHandleScope;
@@ -414,30 +416,30 @@ void Worker::New(const FunctionCallbackInfo<Value>& args) {
414416
if (!args[0]->IsNullOrUndefined()) {
415417
Utf8Value value(
416418
args.GetIsolate(),
417-
args[0]->ToString(env->context()).FromMaybe(v8::Local<v8::String>()));
419+
args[0]->ToString(env->context()).FromMaybe(Local<String>()));
418420
url.append(value.out(), value.length());
419421
}
420422

421423
if (args[1]->IsArray()) {
422-
v8::Local<v8::Array> array = args[1].As<v8::Array>();
424+
Local<Array> array = args[1].As<Array>();
423425
// The first argument is reserved for program name, but we don't need it
424426
// in workers.
425427
has_explicit_exec_argv = true;
426428
std::vector<std::string> exec_argv = {""};
427429
uint32_t length = array->Length();
428430
for (uint32_t i = 0; i < length; i++) {
429-
v8::Local<v8::Value> arg;
431+
Local<Value> arg;
430432
if (!array->Get(env->context(), i).ToLocal(&arg)) {
431433
return;
432434
}
433-
v8::MaybeLocal<v8::String> arg_v8_string =
435+
MaybeLocal<String> arg_v8_string =
434436
arg->ToString(env->context());
435437
if (arg_v8_string.IsEmpty()) {
436438
return;
437439
}
438440
Utf8Value arg_utf8_value(
439441
args.GetIsolate(),
440-
arg_v8_string.FromMaybe(v8::Local<v8::String>()));
442+
arg_v8_string.FromMaybe(Local<String>()));
441443
std::string arg_string(arg_utf8_value.out(), arg_utf8_value.length());
442444
exec_argv.push_back(arg_string);
443445
}
@@ -459,7 +461,7 @@ void Worker::New(const FunctionCallbackInfo<Value>& args) {
459461
// The first argument is program name.
460462
invalid_args.erase(invalid_args.begin());
461463
if (errors.size() > 0 || invalid_args.size() > 0) {
462-
v8::Local<v8::Value> error;
464+
Local<Value> error;
463465
if (!ToV8Value(env->context(),
464466
errors.size() > 0 ? errors : invalid_args)
465467
.ToLocal(&error)) {

0 commit comments

Comments
 (0)