Skip to content

Commit f7886ab

Browse files
TrottMylesBorins
authored andcommitted
test: avoid empty fixture in module test
Refactor test-module-loading to use tmpdir for its empty directory rather than using a not-actually-empty directory called "empty" in fixtures. PR-URL: #21044 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent c74c83a commit f7886ab

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

test/sequential/test-module-loading.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@
2121

2222
'use strict';
2323
const common = require('../common');
24+
const tmpdir = require('../common/tmpdir');
25+
2426
const assert = require('assert');
25-
const path = require('path');
2627
const fs = require('fs');
28+
const path = require('path');
2729

2830
const backslash = /\\/g;
2931

@@ -168,9 +170,10 @@ assert.strictEqual(require('../fixtures/foo').foo, 'ok',
168170

169171
// Should not attempt to load a directory
170172
try {
171-
require('../fixtures/empty');
173+
tmpdir.refresh();
174+
require(tmpdir.path);
172175
} catch (err) {
173-
assert.strictEqual(err.message, 'Cannot find module \'../fixtures/empty\'');
176+
assert.strictEqual(err.message, `Cannot find module '${tmpdir.path}'`);
174177
}
175178

176179
{
@@ -284,7 +287,6 @@ try {
284287
'fixtures/registerExt.test': {},
285288
'fixtures/registerExt.hello.world': {},
286289
'fixtures/registerExt2.test': {},
287-
'fixtures/empty.js': {},
288290
'fixtures/module-load-order/file1': {},
289291
'fixtures/module-load-order/file2.js': {},
290292
'fixtures/module-load-order/file3.node': {},

0 commit comments

Comments
 (0)