Skip to content

Commit f959cb3

Browse files
addaleaxtargos
authored andcommitted
worker: do not look up context twice in PostMessage
Refs: #38780 (comment) PR-URL: #38784 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
1 parent a71df76 commit f959cb3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/node_messaging.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -840,11 +840,11 @@ BaseObjectPtr<BaseObject> MessagePortData::Deserialize(
840840
}
841841

842842
Maybe<bool> MessagePort::PostMessage(Environment* env,
843+
Local<Context> context,
843844
Local<Value> message_v,
844845
const TransferList& transfer_v) {
845846
Isolate* isolate = env->isolate();
846847
Local<Object> obj = object(isolate);
847-
Local<Context> context = obj->GetCreationContext().ToLocalChecked();
848848

849849
std::shared_ptr<Message> msg = std::make_shared<Message>();
850850

@@ -986,7 +986,7 @@ void MessagePort::PostMessage(const FunctionCallbackInfo<Value>& args) {
986986
return;
987987
}
988988

989-
Maybe<bool> res = port->PostMessage(env, args[0], transfer_list);
989+
Maybe<bool> res = port->PostMessage(env, context, args[0], transfer_list);
990990
if (res.IsJust())
991991
args.GetReturnValue().Set(res.FromJust());
992992
}

src/node_messaging.h

+1
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ class MessagePort : public HandleWrap {
242242
// If this port is closed, or if there is no sibling, this message is
243243
// serialized with transfers, then silently discarded.
244244
v8::Maybe<bool> PostMessage(Environment* env,
245+
v8::Local<v8::Context> context,
245246
v8::Local<v8::Value> message,
246247
const TransferList& transfer);
247248

0 commit comments

Comments
 (0)