Skip to content

Commit fac9c4d

Browse files
sam-githubevanlucas
authored andcommitted
src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but implied that Node.js would load modules with newer ABI numbers, which it will not. PR-URL: #10414 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent 68ed276 commit fac9c4d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/node_version.h

+3
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@
4444
(minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION))
4545

4646
/**
47+
* Node.js will refuse to load modules that weren't compiled against its own
48+
* module ABI number, exposed as the process.versions.modules property.
49+
*
4750
* When this version number is changed, node.js will refuse
4851
* to load older modules. This should be done whenever
4952
* an API is broken in the C++ side, including in v8 or

0 commit comments

Comments
 (0)