Skip to content

Commit fb640c6

Browse files
apapirovskiMylesBorins
authored andcommitted
timers: remove domain enter and exit
With domains implemented over AsyncHooks, it's no longer necessary to explicitly enter and exit the domain. PR-URL: #17880 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Andreas Madsen <[email protected]>
1 parent 5df8c76 commit fb640c6

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

lib/timers.js

-17
Original file line numberDiff line numberDiff line change
@@ -256,15 +256,7 @@ function listOnTimeout() {
256256
continue;
257257
}
258258

259-
var domain = timer.domain;
260-
if (domain) {
261-
domain.enter();
262-
}
263-
264259
tryOnTimeout(timer, list);
265-
266-
if (domain)
267-
domain.exit();
268260
}
269261

270262
// If `L.peek(list)` returned nothing, the list was either empty or we have
@@ -688,31 +680,22 @@ var immediateQueue = new ImmediateList();
688680
function processImmediate() {
689681
var immediate = immediateQueue.head;
690682
var tail = immediateQueue.tail;
691-
var domain;
692683

693684
// Clear the linked list early in case new `setImmediate()` calls occur while
694685
// immediate callbacks are executed
695686
immediateQueue.head = immediateQueue.tail = null;
696687

697688
while (immediate !== null) {
698-
domain = immediate.domain;
699-
700689
if (!immediate._onImmediate) {
701690
immediate = immediate._idleNext;
702691
continue;
703692
}
704693

705-
if (domain)
706-
domain.enter();
707-
708694
// Save next in case `clearImmediate(immediate)` is called from callback
709695
var next = immediate._idleNext;
710696

711697
tryOnImmediate(immediate, tail);
712698

713-
if (domain)
714-
domain.exit();
715-
716699
// If `clearImmediate(immediate)` wasn't called from the callback, use the
717700
// `immediate`'s next item
718701
if (immediate._idleNext !== null)

0 commit comments

Comments
 (0)