Skip to content

Commit fbc5cbb

Browse files
cjihrigaduh95
authored andcommittedJul 16, 2024
test_runner: remove plan option from run()
This commit removes the plan option to run(). I believe it was added by mistake. It is not documented, untested, and a test plan does not make sense in the context of run(). This commit also fixes a minor formatting issue in a related fixture. Refs: #52860 PR-URL: #53834 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
1 parent 4d777de commit fbc5cbb

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed
 

‎lib/internal/test_runner/runner.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,6 @@ function run(options = kEmptyObject) {
483483
watch,
484484
setup,
485485
only,
486-
plan,
487486
} = options;
488487

489488
if (files != null) {
@@ -552,7 +551,7 @@ function run(options = kEmptyObject) {
552551
});
553552
}
554553

555-
const root = createTestTree({ __proto__: null, concurrency, timeout, signal, plan });
554+
const root = createTestTree({ __proto__: null, concurrency, timeout, signal });
556555
root.harness.shouldColorizeTestFiles ||= shouldColorizeTestFiles(root);
557556

558557
if (process.env.NODE_TEST_CONTEXT !== undefined) {

‎test/fixtures/test-runner/output/test-runner-plan.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,6 @@ test('planning with streams', (t, done) => {
7474
});
7575

7676
stream.on('end', () => {
77-
done();
77+
done();
7878
});
7979
})

0 commit comments

Comments
 (0)
Please sign in to comment.