Skip to content

Commit fc03224

Browse files
richard-townsend-armcodebytere
authored andcommitted
build: fix GetCurrentThreadStackLimits error on Windows on Arm
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: #33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent d8aeafb commit fc03224

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

tools/v8_gypfiles/v8.gyp

+4-2
Original file line numberDiff line numberDiff line change
@@ -1081,8 +1081,10 @@
10811081
'<(V8_ROOT)/src/base/platform/platform-win32.cc',
10821082
'<(V8_ROOT)/src/base/win32-headers.h',
10831083
],
1084-
1085-
'defines': ['_CRT_RAND_S'], # for rand_s()
1084+
'conditions': [['target_arch == "arm64"', {
1085+
'defines': ['_WIN32_WINNT=0x0602'], # For GetCurrentThreadStackLimits on Windows on Arm
1086+
}]],
1087+
'defines': ['_CRT_RAND_S'], # for rand_s()
10861088
'direct_dependent_settings': {
10871089
'msvs_settings': {
10881090
'VCLinkerTool': {

0 commit comments

Comments
 (0)