Skip to content

Commit fe7ce8c

Browse files
committed
deps,v8: silence V8 self-deprecation warnings
1 parent 9987f1a commit fe7ce8c

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

common.gypi

+6-5
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,20 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.8',
41+
'v8_embedder_string': '-node.9',
4242

4343
##### V8 defaults for Node.js #####
4444

4545
# Old time default, now explicitly stated.
4646
'v8_use_snapshot': 'true',
4747

48+
# These are more relevant for V8 internal development.
4849
# Refs: https://github.com/nodejs/node/issues/23122
4950
# Refs: https://github.com/nodejs/node/issues/23167
50-
# Enable compiler warnings when using V8_DEPRECATED apis.
51-
'v8_deprecation_warnings': 1,
52-
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
53-
'v8_imminent_deprecation_warnings': 1,
51+
# Enable compiler warnings when using V8_DEPRECATED apis from V8 code.
52+
'v8_deprecation_warnings': 0,
53+
# Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code.
54+
'v8_imminent_deprecation_warnings': 0,
5455

5556
# Enable disassembler for `--print-code` v8 options
5657
'v8_enable_disassembler': 1,

deps/v8/gypfiles/features.gypi

+4
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,13 @@
164164
}],
165165
['v8_deprecation_warnings==1', {
166166
'defines': ['V8_DEPRECATION_WARNINGS',],
167+
},{
168+
'defines!': ['V8_DEPRECATION_WARNINGS',],
167169
}],
168170
['v8_imminent_deprecation_warnings==1', {
169171
'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
172+
},{
173+
'defines!': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
170174
}],
171175
['v8_enable_i18n_support==1', {
172176
'defines': ['V8_INTL_SUPPORT',],

0 commit comments

Comments
 (0)