We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent dad7821 commit fefa57aCopy full SHA for fefa57a
src/node_crypto.cc
@@ -2154,9 +2154,6 @@ void SSLWrap<Base>::VerifyError(const FunctionCallbackInfo<Value>& args) {
2154
if (x509_verify_error == X509_V_OK)
2155
return args.GetReturnValue().SetNull();
2156
2157
- // XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe
2158
- // in the presence of invalid error codes. Probably academical but something
2159
- // to keep in mind if/when node ever grows multi-isolate capabilities.
2160
const char* reason = X509_verify_cert_error_string(x509_verify_error);
2161
const char* code = reason;
2162
#define CASE_X509_ERR(CODE) case X509_V_ERR_##CODE: code = #CODE; break;
0 commit comments