Skip to content

Commit fefab90

Browse files
committed
src: only call FatalException if not verbose
This commit attempts to address the TODO regarding not calling FatalException if the try_catch is verbose. PR-URL: #12826 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 986e1d2 commit fefab90

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/node.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -2648,9 +2648,9 @@ void FatalException(Isolate* isolate,
26482648

26492649
void FatalException(Isolate* isolate, const TryCatch& try_catch) {
26502650
HandleScope scope(isolate);
2651-
// TODO(bajtos) do not call FatalException if try_catch is verbose
2652-
// (requires V8 API to expose getter for try_catch.is_verbose_)
2653-
FatalException(isolate, try_catch.Exception(), try_catch.Message());
2651+
if (!try_catch.IsVerbose()) {
2652+
FatalException(isolate, try_catch.Exception(), try_catch.Message());
2653+
}
26542654
}
26552655

26562656

0 commit comments

Comments
 (0)