Skip to content

Commit ff5d632

Browse files
refacktargos
authored andcommitted
build,deps: fix V8 snapshot gyp dependencies
PR-URL: #25852 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent 2f477bd commit ff5d632

File tree

2 files changed

+190
-187
lines changed

2 files changed

+190
-187
lines changed

deps/v8/gypfiles/v8.gyp

+2-76
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
'<(SHARED_INTERMEDIATE_DIR)/torque-generated/builtin-definitions-from-dsl.h',
8080
],
8181
},
82-
'includes': ['toolchain.gypi', 'features.gypi'],
82+
'includes': ['toolchain.gypi', 'features.gypi', 'v8_external_snapshot.gypi'],
8383
'targets': [
8484
{
8585
'target_name': 'v8',
@@ -541,6 +541,7 @@
541541
'dependencies': ['js2c#host'],
542542
}, {
543543
'toolsets': ['target'],
544+
'dependencies': ['js2c#target'],
544545
}],
545546
['component=="shared_library"', {
546547
'defines': [
@@ -2506,78 +2507,6 @@
25062507
],
25072508
},
25082509
}, # v8_libsampler
2509-
{
2510-
'target_name': 'natives_blob',
2511-
'type': 'none',
2512-
'conditions': [
2513-
['want_separate_host_toolset==1', {
2514-
'toolsets': ['host', 'target'],
2515-
}, {
2516-
'toolsets': ['target'],
2517-
}],
2518-
[ 'v8_use_external_startup_data==1', {
2519-
'conditions': [
2520-
['want_separate_host_toolset==1', {
2521-
'dependencies': ['js2c#host'],
2522-
}],
2523-
],
2524-
'actions': [
2525-
{
2526-
'action_name': 'js2c_extras_bin',
2527-
'inputs': [
2528-
'../tools/js2c.py',
2529-
'<@(v8_extra_library_files)',
2530-
],
2531-
'outputs': ['<@(libraries_extras_bin_file)'],
2532-
'action': [
2533-
'python',
2534-
'../tools/js2c.py',
2535-
'<(SHARED_INTERMEDIATE_DIR)/extras-libraries.cc',
2536-
'EXTRAS',
2537-
'<@(v8_extra_library_files)',
2538-
'--startup_blob', '<@(libraries_extras_bin_file)',
2539-
'--nojs',
2540-
],
2541-
},
2542-
{
2543-
'action_name': 'concatenate_natives_blob',
2544-
'inputs': [
2545-
'../tools/concatenate-files.py',
2546-
'<(SHARED_INTERMEDIATE_DIR)/libraries-extras.bin',
2547-
],
2548-
'conditions': [
2549-
['want_separate_host_toolset==1', {
2550-
'target_conditions': [
2551-
['_toolset=="host"', {
2552-
'outputs': [
2553-
'<(PRODUCT_DIR)/natives_blob_host.bin',
2554-
],
2555-
'action': [
2556-
'python', '<@(_inputs)', '<(PRODUCT_DIR)/natives_blob_host.bin'
2557-
],
2558-
}, {
2559-
'outputs': [
2560-
'<(PRODUCT_DIR)/natives_blob.bin',
2561-
],
2562-
'action': [
2563-
'python', '<@(_inputs)', '<(PRODUCT_DIR)/natives_blob.bin'
2564-
],
2565-
}],
2566-
],
2567-
}, {
2568-
'outputs': [
2569-
'<(PRODUCT_DIR)/natives_blob.bin',
2570-
],
2571-
'action': [
2572-
'python', '<@(_inputs)', '<(PRODUCT_DIR)/natives_blob.bin'
2573-
],
2574-
}],
2575-
],
2576-
},
2577-
],
2578-
}],
2579-
]
2580-
}, # natives_blob
25812510
{
25822511
'target_name': 'js2c',
25832512
'type': 'none',
@@ -2830,8 +2759,5 @@
28302759
},
28312760
],
28322761
}, # generate_bytecode_builtins_list
2833-
{
2834-
'includes': [ 'v8_external_snapshot.gypi' ],
2835-
}, # v8_external_snapshot
28362762
],
28372763
}

0 commit comments

Comments
 (0)