Skip to content

Commit ff75d98

Browse files
binarymejasnell
authored andcommitted
test: fix parameters in test-repl.js
fixed order of parameters in assert.strictEqual() assertion functions, first argument provided was the expected value and the second value was the actual value. this is backwards from the documentation for assertions like assert.strictEqual() where the first value being tested and the second value is the expected value PR-URL: #23609 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent c160aac commit ff75d98

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: test/parallel/test-repl.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -784,8 +784,8 @@ function startTCPRepl() {
784784
client.setEncoding('utf8');
785785

786786
client.on('connect', common.mustCall(() => {
787-
assert.strictEqual(true, client.readable);
788-
assert.strictEqual(true, client.writable);
787+
assert.strictEqual(client.readable, true);
788+
assert.strictEqual(client.writable, true);
789789

790790
resolveSocket(client);
791791
}));
@@ -827,8 +827,8 @@ function startUnixRepl() {
827827
client.setEncoding('utf8');
828828

829829
client.on('connect', common.mustCall(() => {
830-
assert.strictEqual(true, client.readable);
831-
assert.strictEqual(true, client.writable);
830+
assert.strictEqual(client.readable, true);
831+
assert.strictEqual(client.writable, true);
832832

833833
resolveSocket(client);
834834
}));

0 commit comments

Comments
 (0)