Skip to content

Commit ffb0bd3

Browse files
richardlaumarco-ippolito
authored andcommitted
build, tools: drop leading / from r2dir
The script is commented as removing `/home/dist/` part but the `cut` command is off by one and end up including the `/` character (so that the resulting string starts with `/`). When this is substituted into `s3://${cloudflare_bucket}/${r2dir}/${shafile}.asc` we end up with `//` (one from the template and one from the `r2dir`) which appears to cause Cloudflare to create an extra top level `/` directory in the bucket. PR-URL: #53951 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent e6ba121 commit ffb0bd3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/release.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ sign() {
158158
# since the promotion script should take care of uploading them.
159159

160160
# Remove /home/dist/ part
161-
r2dir=$(echo "$shadir" | cut -c 11-)
161+
r2dir=$(echo "$shadir" | cut -c 12-)
162162

163163
# Copy SHASUMS256.txt.asc
164164
# shellcheck disable=SC2086,SC2029

0 commit comments

Comments
 (0)