Skip to content

Commit ffb7deb

Browse files
evanlucasMyles Borins
authored and
Myles Borins
committed
net: remove hot path comment from connect
This comment was added with an assumption that we could determine the IP address that localhost should resolve to without performing a lookup. This was a false assumption and should be removed. PR-URL: #4648 Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent b70eec8 commit ffb7deb

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lib/net.js

-1
Original file line numberDiff line numberDiff line change
@@ -931,7 +931,6 @@ function lookupAndConnect(self, options) {
931931
port |= 0;
932932

933933
// If host is an IP, skip performing a lookup
934-
// TODO(evanlucas) should we hot path this for localhost?
935934
var addressType = exports.isIP(host);
936935
if (addressType) {
937936
process.nextTick(function() {

0 commit comments

Comments
 (0)