Skip to content

Commit ffe572a

Browse files
bnoordhuisMylesBorins
authored andcommitted
src: replace assert() with CHECK()
PR-URL: #14663 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent 34d1a77 commit ffe572a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/node_http2_core-inl.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ inline ssize_t Nghttp2Session::OnStreamRead(nghttp2_session *session,
285285

286286
GetTrailers(session, handle, stream, flags);
287287
}
288-
assert(offset <= length);
288+
CHECK(offset <= length);
289289
return offset;
290290
}
291291

@@ -296,7 +296,7 @@ inline ssize_t Nghttp2Session::OnSelectPadding(nghttp2_session *session,
296296
size_t maxPayloadLen,
297297
void *user_data) {
298298
Nghttp2Session *handle = static_cast<Nghttp2Session *>(user_data);
299-
assert(handle->HasGetPaddingCallback());
299+
CHECK(handle->HasGetPaddingCallback());
300300
ssize_t padding = handle->GetPadding(frame->hd.length, maxPayloadLen);
301301
DEBUG_HTTP2("Nghttp2Session %s: using padding, size: %d\n",
302302
handle->TypeName(), padding);
@@ -547,7 +547,7 @@ inline void Nghttp2Session::MarkDestroying() {
547547
}
548548

549549
inline int Nghttp2Session::Free() {
550-
assert(session_ != nullptr);
550+
CHECK(session_ != nullptr);
551551
DEBUG_HTTP2("Nghttp2Session %s: freeing session\n", TypeName());
552552
// Stop the loop
553553
uv_prepare_stop(&prep_);

0 commit comments

Comments
 (0)