Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2bb93e11085ea582aea1636f544d900520d479ed
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f11a4ec638b2e159d6ed8840e2e6f1cc972f41a3
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Jun 25, 2019

  1. stream: add writableFinished 

    add a new getter to duplex stream to replace the property `this
.writableState.finished` of the object that inherited duplex.

Refs: #445

PR-URL: #28007
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
    @zero1five @Trott
    zero1five authored and Trott committed Jun 25, 2019
    Copy the full SHA
    33aef82 View commit details

  2. http2: use writableFinished instead of _writableState 

    PR-URL: #28007
Refs: #445
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
    @zero1five @Trott
    zero1five authored and Trott committed Jun 25, 2019
    Copy the full SHA
    f11a4ec View commit details
Loading