Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 375b859428e1c525f0cc9d3c4324f51740316722
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0e1fd8d0b42340039ae4086fa23c062d1a2dee74
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Aug 16, 2020

  1. test: allow ENFILE in test-worker-init-failure 

    Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
    @Trott
    Trott committed Aug 16, 2020
    Copy the full SHA
    97d9b9c View commit details

  2. test: allow ENOENT in test-worker-init-failure 

    PR-URL: #34769
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
    @Trott
    Trott committed Aug 16, 2020
    Copy the full SHA
    0e1fd8d View commit details
Showing with 5 additions and 3 deletions.
  1. +5 −3 test/parallel/test-worker-init-failure.js
8 changes: 5 additions & 3 deletions test/parallel/test-worker-init-failure.js
View file
Original file line number Diff line number Diff line change
@@ -30,12 +30,14 @@ if (process.argv[2] === 'child') {
});

// We want to test that if there is an error in a constrained running
// environment, it will be one of `EMFILE` or `ERR_WORKER_INIT_FAILED`.
// environment, it will be one of `ENFILE`, `EMFILE`, 'ENOENT', or
// `ERR_WORKER_INIT_FAILED`.
const expected = ['ERR_WORKER_INIT_FAILED', 'EMFILE', 'ENFILE', 'ENOENT'];

// `common.mustCall*` cannot be used here as in some environments
// (i.e. single cpu) `ulimit` may not lead to such an error.

worker.on('error', (e) => {
assert.ok(e.code === 'ERR_WORKER_INIT_FAILED' || e.code === 'EMFILE');
assert.ok(expected.includes(e.code), `${e.code} not expected`);
});
}