Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bd99e8de8e4
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a804026c9b
Choose a head ref
  • 9 commits
  • 8 files changed
  • 5 contributors

Commits on Jun 3, 2015

  1. test: remove hardwired references to 'iojs' 

    PR-URL: #1882
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
    @rvagg @silverwind
    rvagg authored and silverwind committed Jun 3, 2015

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Learn about vigilant mode
    Copy the full SHA
    f78c722 View commit details

  2. test: running tls-server-verify clients in parallel 

    OpenSSL s_client introduces some delay on Windows. With all clients
running sequentially, this delay is big enough to break CI. This fix runs
the clients in parallel (unless the test includes renegotiation),
reducing the total run time.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
    @joaocgreis @orangemocha
    joaocgreis authored and orangemocha committed Jun 3, 2015
    Copy the full SHA
    b18604b View commit details

  3. test: run tls-server-verify servers in parallel 

    Different servers must use different ports. Since we can count only on
common.PORT and common.PORT+1, run only 2 servers in parallel.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
    @joaocgreis @orangemocha
    joaocgreis authored and orangemocha committed Jun 3, 2015
    Copy the full SHA
    975e595 View commit details

  4. test: improve console output of tls-server-verify 

    When running in parallel, it is not easy to identify what server and
client failed when the test fails. This adds identifiers to all lines
of console output.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
    @joaocgreis @orangemocha
    joaocgreis authored and orangemocha committed Jun 3, 2015
    Copy the full SHA
    e6ccdcc View commit details

  5. test: kill child in tls-server-verify for speed up 

    For better performance of the test, the parent kills child processes
so as not to wait them to be ended.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
    @orangemocha
    Shigeki Ohtsu authored and orangemocha committed Jun 3, 2015
    Copy the full SHA
    4cf323d View commit details

  6. deps: add -no_rand_screen to openssl s_client 

    In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
    @orangemocha
    Shigeki Ohtsu authored and orangemocha committed Jun 3, 2015
    Copy the full SHA
    0ee497f View commit details

  7. test: add -no_rand_screen for tls-server-verify 

    This improves the performance of openssl s_client on Windows and
gains several seconds to finish test-tls-server-verify.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
    @orangemocha
    Shigeki Ohtsu authored and orangemocha committed Jun 3, 2015
    Copy the full SHA
    4ed25f6 View commit details

  8. test: fix test-sync-io-option 

    This test was failing occasionally both locally and on CI. Switched
from using spawn to execFile for a more reliable test.

Fixes: #1837
PR-URL: #1840
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
    @evanlucas
    evanlucas committed Jun 3, 2015
    Copy the full SHA
    43a82f8 View commit details

  9. test: fix broken FreeBSD test 

    Fixes net-server-max-connections-close-makes-more-available
Handles connection 'error' event so the test ends.

PR-URL: #1881
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Brendan Ashworth <[email protected]>
    @santigimeno @brendanashworth
    santigimeno authored and brendanashworth committed Jun 3, 2015
    Copy the full SHA
    a804026 View commit details
Loading