Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c44de49cdb9ffc1dd01ba1fbb6e5557102ce51cc
Choose a base ref
..
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bc9e25f020900b17960924bed5269a7f8ae2d820
Choose a head ref
Showing with 7 additions and 7 deletions.
  1. +2 βˆ’2 benchmark/fs/readfile-partitioned.js
  2. +2 βˆ’2 benchmark/fs/readfile-permission-enabled.js
  3. +1 βˆ’1 benchmark/fs/readfile-promises.js
  4. +1 βˆ’1 benchmark/fs/readfile.js
  5. +1 βˆ’1 benchmark/fs/writefile-promises.js
4 changes: 2 additions & 2 deletions benchmark/fs/readfile-partitioned.js
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@
const path = require('path');
const common = require('../common.js');
const filename = path.resolve(__dirname,
`.removeme-benchmark-garbage-${process.pid}`);
`.removeme-benchmark-garbage-${process.pid}`);
const fs = require('fs');
const zlib = require('zlib');
const assert = require('assert');
@@ -44,7 +44,7 @@ function main({ len, duration, concurrent, encoding }) {
benchEnded = true;
bench.end(totalOps);

// this delay is needed because on windows this can cause
// This delay is needed because on windows this can cause
// race condition with afterRead, which makes this benchmark
// fails to delete the temp file
setTimeout(() => {
4 changes: 2 additions & 2 deletions benchmark/fs/readfile-permission-enabled.js
Original file line number Diff line number Diff line change
@@ -39,10 +39,10 @@ function main({ len, duration, concurrent, encoding }) {
let benchEnded = false;
bench.start();
setTimeout(() => {
benchEnded = true
benchEnded = true;
bench.end(reads);

// this delay is needed because on windows this can cause
// This delay is needed because on windows this can cause
// race condition with afterRead, which makes this benchmark
// fails to delete the temp file
setTimeout(() => {
2 changes: 1 addition & 1 deletion benchmark/fs/readfile-promises.js
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ function main({ len, duration, concurrent, encoding }) {
benchEnded = true;
bench.end(writes);

// this delay is needed because on windows this can cause
// This delay is needed because on windows this can cause
// race condition with afterRead, which makes this benchmark
// fails to delete the temp file
setTimeout(() => {
2 changes: 1 addition & 1 deletion benchmark/fs/readfile.js
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ function main({ len, duration, concurrent, encoding }) {
benchEnded = true;
bench.end(reads);

// this delay is needed because on windows this can cause
// This delay is needed because on windows this can cause
// race condition with afterRead, which makes this benchmark
// fails to delete the temp file
setTimeout(() => {
2 changes: 1 addition & 1 deletion benchmark/fs/writefile-promises.js
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ function main({ encodingType, duration, concurrent, size }) {
benchEnded = true;
bench.end(writes);

// this delay is needed because on windows this can cause
// This delay is needed because on windows this can cause
// race condition with afterRead, which makes this benchmark
// fails to delete the temp file
setTimeout(() => {